diff options
| author |   bbaetz%student.usyd.edu.au <> | 2002-06-28 07:18:02 +0000 |
|---|---|---|
| committer | bbaetz%student.usyd.edu.au <> | 2002-06-28 07:18:02 +0000 |
| commit | d5f30d8dfda359d6761d164d3c650adf1716213b (patch) | |
| tree | 4f2ee142ba674fa30f1b0f45781ed935e3b405d5 | |
| parent | Bug 154036 - ccing an invalid user on a bug posts the bug anyway (diff) | |
| download | bugzilla-d5f30d8dfda359d6761d164d3c650adf1716213b.tar.gz bugzilla-d5f30d8dfda359d6761d164d3c650adf1716213b.tar.bz2 bugzilla-d5f30d8dfda359d6761d164d3c650adf1716213b.zip | |
Bug 148488 - more HTML validation fixes
r=jouni, gerv
23 files changed, 69 insertions, 70 deletions
@@ -353,21 +353,21 @@ sub navigation_links($) { my $cur = lsearch(\@bugs, $::FORM{"id"}); if ($cur > 0) { - $retval .= "<link rel=\"First\" href=\"show_bug.cgi?id=$bugs[0]\" />\n"; - $retval .= "<link rel=\"Prev\" href=\"show_bug.cgi?id=$bugs[$cur - 1]\" />\n"; + $retval .= "<link rel=\"First\" href=\"show_bug.cgi?id=$bugs[0]\">\n"; + $retval .= "<link rel=\"Prev\" href=\"show_bug.cgi?id=$bugs[$cur - 1]\">\n"; } if ($cur < $#bugs) { - $retval .= "<link rel=\"Next\" href=\"show_bug.cgi?id=$bugs[$cur + 1]\" />\n"; - $retval .= "<link rel=\"Last\" href=\"show_bug.cgi?id=$bugs[$#bugs]\" />\n"; + $retval .= "<link rel=\"Next\" href=\"show_bug.cgi?id=$bugs[$cur + 1]\">\n"; + $retval .= "<link rel=\"Last\" href=\"show_bug.cgi?id=$bugs[$#bugs]\">\n"; } - $retval .= "<link rel=\"Up\" href=\"buglist.cgi?regetlastlist=1\" />\n"; - $retval .= "<link rel=\"Contents\" href=\"buglist.cgi?regetlastlist=1\" />\n"; + $retval .= "<link rel=\"Up\" href=\"buglist.cgi?regetlastlist=1\">\n"; + $retval .= "<link rel=\"Contents\" href=\"buglist.cgi?regetlastlist=1\">\n"; } else { # We are on a bug list - $retval .= "<link rel=\"First\" href=\"show_bug.cgi?id=$bugs[0]\" />\n"; - $retval .= "<link rel=\"Next\" href=\"show_bug.cgi?id=$bugs[0]\" />\n"; - $retval .= "<link rel=\"Last\" href=\"show_bug.cgi?id=$bugs[$#bugs]\" />\n"; + $retval .= "<link rel=\"First\" href=\"show_bug.cgi?id=$bugs[0]\">\n"; + $retval .= "<link rel=\"Next\" href=\"show_bug.cgi?id=$bugs[0]\">\n"; + $retval .= "<link rel=\"Last\" href=\"show_bug.cgi?id=$bugs[$#bugs]\">\n"; } } @@ -972,7 +972,7 @@ sub ThrowTemplateError { send it to $maintainer with details of what you were doing at the time this message appeared. </p> - <script> <!-- + <script type="text/javascript"> <!-- document.write("<p>URL: " + document.location + "</p>"); // --> </script> diff --git a/buglist.cgi b/buglist.cgi index edbe4c021..c2d44de12 100755 --- a/buglist.cgi +++ b/buglist.cgi @@ -832,7 +832,7 @@ sub GenerateSQL { $F{"type$chart-$row-$col"} = shift(@$ref); $F{"value$chart-$row-$col"} = shift(@$ref); if ($debug) { - print qq{<P>$F{"field$chart-$row-$col"} | $F{"type$chart-$row-$col"} | $F{"value$chart-$row-$col"}*\n}; + print qq{<p>$F{"field$chart-$row-$col"} | $F{"type$chart-$row-$col"} | $F{"value$chart-$row-$col"}*</p>\n}; } $col++; @@ -971,7 +971,7 @@ sub GenerateSQL { if ("$f,$t" =~ m/$key/) { my $ref = $funcsbykey{$key}; if ($debug) { - print "<P>$key ($f , $t ) => "; + print "<p>$key ($f , $t ) => "; } $ff = $f; if ($f !~ /\./) { @@ -979,7 +979,7 @@ sub GenerateSQL { } &$ref; if ($debug) { - print "$f , $t , $term"; + print "$f , $t , $term</p>"; } if ($term) { last; @@ -1020,7 +1020,7 @@ sub GenerateSQL { $query = SelectVisible($query, $::userid, $::usergroupset); if ($debug) { - print "<P><CODE>" . value_quote($query) . "</CODE><P>\n"; + print "<p><code>" . value_quote($query) . "</code></p>\n"; exit; } return $query; diff --git a/changepassword.cgi b/changepassword.cgi index dafe5c1ae..1bc560c17 100755 --- a/changepassword.cgi +++ b/changepassword.cgi @@ -24,16 +24,16 @@ use strict; print q{Content-type: text/html -<HTML> -<HEAD> -<META HTTP-EQUIV="Refresh" - CONTENT="0; URL=userprefs.cgi"> -</HEAD> -<BODY> +<html> +<head> +<meta http-equiv="Refresh" + content="0; URL=userprefs.cgi"> +</head> +<body> This URL is obsolete. Forwarding you to the correct one. -<P> -Going to <A HREF="userprefs.cgi">userprefs.cgi</A> -<BR> -</BODY> -</HTML> +<p> +Going to <a href="userprefs.cgi">userprefs.cgi</a> +<br> +</body> +</html> } diff --git a/checksetup.pl b/checksetup.pl index 0f9e2328f..738f99386 100755 --- a/checksetup.pl +++ b/checksetup.pl @@ -806,14 +806,14 @@ if ($my_index_html) { open HTML, ">index.html"; print HTML <<'END'; <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> -<HTML> -<HEAD> -<META HTTP-EQUIV="REFRESH" CONTENT="0; URL=index.cgi"> -</HEAD> -<BODY> -<H1>I think you are looking for <a href="index.cgi">index.cgi</a></H1> -</BODY> -</HTML> +<html> +<head> +<meta http-equiv="Refresh" content="0; URL=index.cgi"> +</head> +<body> +<h1>I think you are looking for <a href="index.cgi">index.cgi</a></h1> +</body> +</html> END close HTML; } diff --git a/colchange.cgi b/colchange.cgi index 64dd9c4a5..727ad2c90 100755 --- a/colchange.cgi +++ b/colchange.cgi @@ -88,8 +88,8 @@ if (defined $::FORM{'rememberedquery'}) { print "Set-Cookie: SPLITHEADER=$::FORM{'splitheader'} ; path=$cookiepath ; expires=Sun, 30-Jun-2029 00:00:00 GMT\n"; print "Refresh: 0; URL=buglist.cgi?$::FORM{'rememberedquery'}\n"; print "\n"; - print "<META HTTP-EQUIV=Refresh CONTENT=\"1; URL=$urlbase"."buglist.cgi?$::FORM{'rememberedquery'}\">\n"; - print "<TITLE>What a hack.</TITLE>\n"; + print "<meta http-equiv=\"Refresh\" content=\"1; URL=$urlbase"."buglist.cgi?$::FORM{'rememberedquery'}\">\n"; + print "<title>What a hack.</title>\n"; PutHeader ("Change columns"); print "Resubmitting your query with new columns...\n"; exit; diff --git a/defparams.pl b/defparams.pl index 2ba6a31c5..f4fd85f6f 100644 --- a/defparams.pl +++ b/defparams.pl @@ -204,7 +204,7 @@ DefParam("LDAPmailattribute", DefParam("mostfreqthreshold", - "The minimum number of duplicates a bug needs to show up on the <A HREF=\"duplicates.cgi\">most frequently reported bugs page</a>. If you have a large database and this page takes a long time to load, try increasing this number.", + "The minimum number of duplicates a bug needs to show up on the <a href=\"duplicates.cgi\">most frequently reported bugs page</a>. If you have a large database and this page takes a long time to load, try increasing this number.", "t", "2"); diff --git a/globals.pl b/globals.pl index f32fc1f3d..6e84cb0da 100644 --- a/globals.pl +++ b/globals.pl @@ -947,7 +947,7 @@ sub DBNameToIdAndCheck { } $name = html_quote($name); - ThrowUserError("The name <TT>$name</TT> is not a valid username. + ThrowUserError("The name <tt>$name</tt> is not a valid username. Either you misspelled it, or the person has not registered for a Bugzilla account."); } diff --git a/sanitycheck.cgi b/sanitycheck.cgi index 4172e6b34..706d7dff5 100755 --- a/sanitycheck.cgi +++ b/sanitycheck.cgi @@ -55,17 +55,17 @@ my $offervotecacherebuild = 0; sub Status { my ($str) = (@_); - print "$str <P>\n"; + print "$str <p>\n"; } sub Alert { my ($str) = (@_); - Status("<font color=red>$str</font>"); + Status("<font color=\"red\">$str</font>"); } sub BugLink { my ($id) = (@_); - return "<a href='show_bug.cgi?id=$id'>$id</a>"; + return "<a href=\"show_bug.cgi?id=$id\">$id</a>"; } sub AlertBadVoteCache { @@ -142,7 +142,7 @@ if (exists $::FORM{'rebuildvotecache'}) { Status("Vote cache has been rebuilt."); } -print "OK, now running sanity checks.<P>\n"; +print "OK, now running sanity checks.<p>\n"; # This one goes first, because if this is wrong, then the below tests # will probably fail too diff --git a/showdependencygraph.cgi b/showdependencygraph.cgi index 4df71ac49..cf2122540 100755 --- a/showdependencygraph.cgi +++ b/showdependencygraph.cgi @@ -45,10 +45,10 @@ sub CreateImagemap { open MAP, "<$mapfilename"; while(my $line = <MAP>) { if($line =~ /^default ([^ ]*)(.*)$/) { - $default = qq{<area shape="default" href="$1">\n}; + $default = qq{<area alt="" shape="default" href="$1">\n}; } if ($line =~ /^rectangle \((.*),(.*)\) \((.*),(.*)\) (http[^ ]*)(.*)?$/) { - $map .= qq{<area name="bug$6" shape="rect" href="$5" coords="$1,$4,$3,$2">\n}; + $map .= qq{<area alt="bug$6" name="bug$6" shape="rect" href="$5" coords="$1,$4,$3,$2">\n}; } } close MAP; diff --git a/template/en/default/account/email/confirm.html.tmpl b/template/en/default/account/email/confirm.html.tmpl index 140c54e0d..0b1ea5334 100644 --- a/template/en/default/account/email/confirm.html.tmpl +++ b/template/en/default/account/email/confirm.html.tmpl @@ -35,7 +35,7 @@ <table> <tr> <th align="right">Old Email Address:</th> - <td><input type="input" name="email" size="36"></td> + <td><input type="text" name="email" size="36"></td> </tr> <tr> <th align="right"> </th> diff --git a/template/en/default/account/prefs/prefs.html.tmpl b/template/en/default/account/prefs/prefs.html.tmpl index 2a232f875..d455b5b66 100644 --- a/template/en/default/account/prefs/prefs.html.tmpl +++ b/template/en/default/account/prefs/prefs.html.tmpl @@ -97,7 +97,7 @@ <h3>[% current_tab.description %]</h3> -<form method="post"> +<form method="post" action="userprefs.cgi"> <input type="hidden" name="tab" value="[% current_tab.name %]"> [% PROCESS "account/prefs/${current_tab.name}.html.tmpl" IF current_tab.name.defined %] diff --git a/template/en/default/admin/attachstatus/delete.html.tmpl b/template/en/default/admin/attachstatus/delete.html.tmpl index e92b97985..0d5285128 100644 --- a/template/en/default/admin/attachstatus/delete.html.tmpl +++ b/template/en/default/admin/attachstatus/delete.html.tmpl @@ -34,13 +34,13 @@ <table> <tr> - <td colspan=2> + <td colspan="2"> Do you really want to delete this status? </td> </tr> <tr> <td> - <a href="editattachstatuses.cgi?action=delete&id=[% id %]"> + <a href="editattachstatuses.cgi?action=delete&id=[% id %]"> Yes, delete </a> </td> diff --git a/template/en/default/admin/attachstatus/list.html.tmpl b/template/en/default/admin/attachstatus/list.html.tmpl index 67d5640ae..1640d6e1b 100644 --- a/template/en/default/admin/attachstatus/list.html.tmpl +++ b/template/en/default/admin/attachstatus/list.html.tmpl @@ -55,10 +55,10 @@ <td>[% statusdef.sortkey %]</td> <td>[% statusdef.product FILTER html %]</td> <td> - <a href="editattachstatuses.cgi?action=edit&id=[% statusdef.id %]"> + <a href="editattachstatuses.cgi?action=edit&id=[% statusdef.id %]"> Edit</a> | - <a href="editattachstatuses.cgi?action=confirmdelete&id=[% statusdef.id %]" + <a href="editattachstatuses.cgi?action=confirmdelete&id=[% statusdef.id %]" onclick="return confirmDelete([% statusdef.attachcount %], '[% statusdef.name FILTER js %]', [% statusdef.id %]);"> @@ -76,7 +76,7 @@ </tr> </table> -<script language="JavaScript"> +<script language="JavaScript" type="text/javascript"><!-- function confirmDelete(attachcount, name, id) { if (attachcount > 0) { @@ -94,6 +94,7 @@ } return false; } +--> </script> [% PROCESS global/footer.html.tmpl %] diff --git a/template/en/default/attachment/edit.html.tmpl b/template/en/default/attachment/edit.html.tmpl index 873f73b59..ca72647dd 100644 --- a/template/en/default/attachment/edit.html.tmpl +++ b/template/en/default/attachment/edit.html.tmpl @@ -53,7 +53,7 @@ var contentType = '[% contenttype %]'; if ( contentType == 'text/plain' ) { - theContent = theContent.replace( /^<html><head\/><body><pre>/i , "" ); + theContent = theContent.replace( /^<html><head\/?><body><pre>/i , "" ); theContent = theContent.replace( /<\/pre><\/body><\/html>$/i , "" ); theContent = theContent.replace( /</gi , "<" ); theContent = theContent.replace( />/gi , ">" ); diff --git a/template/en/default/attachment/show-multiple.html.tmpl b/template/en/default/attachment/show-multiple.html.tmpl index b3c05f2e2..6d192ad89 100644 --- a/template/en/default/attachment/show-multiple.html.tmpl +++ b/template/en/default/attachment/show-multiple.html.tmpl @@ -86,7 +86,7 @@ [% ELSE %] <p><b> Attachment cannot be viewed because its MIME type is not text/*, image/*, or application/vnd.mozilla.*. - <a href="attachment.cgi?id=[% a.attachid %]&action=view">Download the attachment instead</a>. + <a href="attachment.cgi?id=[% a.attachid %]&action=view">Download the attachment instead</a>. </b></p> [% END %] </div> diff --git a/template/en/default/bug/dependency-graph.html.tmpl b/template/en/default/bug/dependency-graph.html.tmpl index 8206a847b..2d505a371 100644 --- a/template/en/default/bug/dependency-graph.html.tmpl +++ b/template/en/default/bug/dependency-graph.html.tmpl @@ -51,16 +51,16 @@ </p> [% IF image_map %] - <img src="[% image_url %]" usemap="#imagemap"> + <img src="[% image_url %]" alt="Dependency graph" usemap="#imagemap"> [% ELSE %] <a href="[% map_url %]"> - <img src="[% image_url %]" ismap="ismap"> + <img src="[% image_url %]" alt="Dependency graph" ismap="ismap"> </a> [% END %] <hr> -<form> +<form action="showdependencygraph.cgi"> <table> <tr> <td> diff --git a/template/en/default/bug/process/confirm-duplicate.html.tmpl b/template/en/default/bug/process/confirm-duplicate.html.tmpl index 172571900..ff8721653 100644 --- a/template/en/default/bug/process/confirm-duplicate.html.tmpl +++ b/template/en/default/bug/process/confirm-duplicate.html.tmpl @@ -49,7 +49,7 @@ Do you wish to do this? </p> -<form method="post"> +<form method="post" action="process_bug.cgi"> [% PROCESS "global/hidden-fields.html.tmpl" exclude="^(Bugzilla|LDAP)_(login|password)$" %] diff --git a/template/en/default/bug/process/midair.html.tmpl b/template/en/default/bug/process/midair.html.tmpl index a30e89b3c..24766aa04 100644 --- a/template/en/default/bug/process/midair.html.tmpl +++ b/template/en/default/bug/process/midair.html.tmpl @@ -59,7 +59,7 @@ You have the following choices: <ul> <li> - <form method="post"> + <form method="post" action="process_bug.cgi"> [% PROCESS "global/hidden-fields.html.tmpl" exclude="^(Bugzilla|LDAP)_(login|password)$" %] <input type="submit" value="Submit my changes anyway"> This will cause all of the above changes to be overwritten diff --git a/template/en/default/bug/show-multiple.html.tmpl b/template/en/default/bug/show-multiple.html.tmpl index 0e73f4ad7..7c3e7407f 100644 --- a/template/en/default/bug/show-multiple.html.tmpl +++ b/template/en/default/bug/show-multiple.html.tmpl @@ -42,7 +42,7 @@ [%###########################################################################%] [% BLOCK bug_display %] - <img src="1x1.gif" width="1" height="80" align="left"> + <img alt="" src="1x1.gif" width="1" height="80" align="left"> <div align="center"> <b> <font ="+3">Bug [% bug.bug_id %] - [% bug.short_desc FILTER html %]</font> diff --git a/template/en/default/global/code-error.html.tmpl b/template/en/default/global/code-error.html.tmpl index 637fba6b1..4b5ac2f67 100644 --- a/template/en/default/global/code-error.html.tmpl +++ b/template/en/default/global/code-error.html.tmpl @@ -36,7 +36,7 @@ it to [% Param("maintainer") %] with details of what you were doing at the time this message appeared. </p> - <script> <!-- + <script type="text/javascript"> <!-- document.write("<p>URL: " + document.location + "</p>"); // --> </script> diff --git a/template/en/default/global/useful-links.html.tmpl b/template/en/default/global/useful-links.html.tmpl index 807c316b6..d8c443775 100644 --- a/template/en/default/global/useful-links.html.tmpl +++ b/template/en/default/global/useful-links.html.tmpl @@ -43,7 +43,7 @@ Actions: </td> - <td valign="middle" nowrap> + <td valign="middle" nowrap="nowrap"> <a href="enter_bug.cgi">New</a> | <a href="query.cgi">Query</a> | @@ -63,19 +63,19 @@ <td valign="middle"> Edit <a href="userprefs.cgi">prefs</a> - [% ", <a href='editparams.cgi'>parameters</a>" + [% ', <a href="editparams.cgi">parameters</a>' IF user.groups.tweakparams %] - [% ", <a href='editusers.cgi'>users</a>" IF user.groups.editusers + [% ', <a href="editusers.cgi">users</a>' IF user.groups.editusers || (user.blessgroupset > 0) %] - [% ", <a href='editproducts.cgi'>products</a>" + [% ', <a href="editproducts.cgi">products</a>' IF user.groups.editcomponents %] - [% ", <a href='editattachstatuses.cgi'> attachment statuses</a>" + [% ', <a href="editattachstatuses.cgi"> attachment statuses</a>' IF user.groups.editcomponents %] - [% ", <a href='editgroups.cgi'>groups</a>" + [% ', <a href="editgroups.cgi">groups</a>' IF user.groups.creategroups %] - [% ", <a href='editkeywords.cgi'>keywords</a>" + [% ', <a href="editkeywords.cgi">keywords</a>' IF user.groups.editkeywords %] - [% " | <a href='sanitycheck.cgi'>Sanity check</a>" + [% ' | <a href="sanitycheck.cgi">Sanity check</a>' IF user.groups.tweakparams %] | <a href="relogin.cgi">Log out</a> [% user.login %] diff --git a/template/en/default/list/edit-multiple.html.tmpl b/template/en/default/list/edit-multiple.html.tmpl index eb8e759be..a9ee9a121 100644 --- a/template/en/default/list/edit-multiple.html.tmpl +++ b/template/en/default/list/edit-multiple.html.tmpl @@ -247,7 +247,7 @@ <select name="resolution" onchange="document.forms.changeform.knob[[% knum %]].checked=true"> [% FOREACH resolution = resolutions %] [% NEXT IF !resolution %] - <option value="[% resolution FILTER html %]" [% selected IF resolution == "FIXED" %]> + <option value="[% resolution FILTER html %]" [% 'selected="selected"' IF resolution == "FIXED" %]> [% resolution FILTER html %] </option> [% END %] diff --git a/template/en/default/search/form.html.tmpl b/template/en/default/search/form.html.tmpl index 8627b448a..6de37286f 100644 --- a/template/en/default/search/form.html.tmpl +++ b/template/en/default/search/form.html.tmpl @@ -651,8 +651,6 @@ function selectProduct(f) { </tr> </table> -[%# Note: the <form> tag is unclosed at the end of this template %] - [%############################################################################%] [%# Block for SELECT fields #%] [%############################################################################%] |