diff options
| author |   Alan Modra <amodra@gmail.com> | 2013-08-17 18:21:58 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2013-10-04 10:31:41 +0930 |
| commit | 1b6adf888de14675bc3207578dcb7132ed5f8ecc (patch) | |
| tree | d3f1bc0076f24429772ea316b624fcc5bf7bebd8 /ports | |
| parent | Fix for [BZ #15680] IBM long double inaccuracy (diff) | |
| download | glibc-1b6adf888de14675bc3207578dcb7132ed5f8ecc.tar.gz glibc-1b6adf888de14675bc3207578dcb7132ed5f8ecc.tar.bz2 glibc-1b6adf888de14675bc3207578dcb7132ed5f8ecc.zip | |
PowerPC floating point little-endian [1 of 15]
http://sourceware.org/ml/libc-alpha/2013-08/msg00081.html
This is the first of a series of patches to ban ieee854_long_double
and the ieee854_long_double macros when using IBM long double. union
ieee854_long_double just isn't correct for IBM long double, especially
when little-endian, and pretending it is OK has allowed a number of
bugs to remain undetected in sysdeps/ieee754/ldbl-128ibm/.
This changes the few places in generic code that use it.
* stdio-common/printf_size.c (__printf_size): Don't use
union ieee854_long_double in fpnum union.
* stdio-common/printf_fphex.c (__printf_fphex): Likewise. Use
signbit macro to retrieve sign from long double.
* stdio-common/printf_fp.c (___printf_fp): Use signbit macro to
retrieve sign from long double.
* sysdeps/ieee754/ldbl-128ibm/printf_fphex.c: Adjust for fpnum change.
* sysdeps/ieee754/ldbl-128/printf_fphex.c: Likewise.
* sysdeps/ieee754/ldbl-96/printf_fphex.c: Likewise.
* sysdeps/x86_64/fpu/printf_fphex.c: Likewise.
* math/test-misc.c (main): Don't use union ieee854_long_double.
ports/
* sysdeps/ia64/fpu/printf_fphex.c: Adjust for fpnum change.
Diffstat (limited to 'ports')
| -rw-r--r-- | ports/ChangeLog | 4 | ||||
| -rw-r--r-- | ports/sysdeps/ia64/fpu/printf_fphex.c | 10 |
2 files changed, 10 insertions, 4 deletions
diff --git a/ports/ChangeLog b/ports/ChangeLog index 9b638017f8..d1875f4fd9 100644 --- a/ports/ChangeLog +++ b/ports/ChangeLog @@ -1,3 +1,7 @@ +2013-19-04 Alan Modra <amodra@gmail.com> + + * sysdeps/ia64/fpu/printf_fphex.c: Adjust for fpnum change. + 2013-09-02 Mike Frysinger <vapier@gentoo.org> * sysdeps/unix/sysv/linux/hppa/syscalls.list (fanotify_mark): New diff --git a/ports/sysdeps/ia64/fpu/printf_fphex.c b/ports/sysdeps/ia64/fpu/printf_fphex.c index ca021427ec..0698cdad10 100644 --- a/ports/sysdeps/ia64/fpu/printf_fphex.c +++ b/ports/sysdeps/ia64/fpu/printf_fphex.c @@ -25,9 +25,11 @@ do { \ /* The "strange" 80 bit format on ia64 has an explicit \ leading digit in the 64 bit mantissa. */ \ unsigned long long int num; \ + union ieee854_long_double u; \ + u.d = fpnum.ldbl; \ \ - num = (((unsigned long long int) fpnum.ldbl.ieee.mantissa0) << 32 \ - | fpnum.ldbl.ieee.mantissa1); \ + num = (((unsigned long long int) u.ieee.mantissa0) << 32 \ + | u.ieee.mantissa1); \ \ zero_mantissa = num == 0; \ \ @@ -49,8 +51,8 @@ do { \ \ /* We have 3 bits from the mantissa in the leading nibble. \ Therefore we are here using `IEEE854_LONG_DOUBLE_BIAS + 3'. */ \ - exponent = fpnum.ldbl.ieee.exponent; \ - \ + exponent = u.ieee.exponent; \ + \ if (exponent == 0) \ { \ if (zero_mantissa) \ |