diff options
author | John Helmert III <ajak@gentoo.org> | 2023-12-25 14:12:07 -0800 |
---|---|---|
committer | John Helmert III <ajak@gentoo.org> | 2023-12-25 14:12:07 -0800 |
commit | d2cd457ff85b3a970497b199ebb7e8668633c79e (patch) | |
tree | ec67656703b0b9649bed3137c50e50ce6495c11c | |
parent | test_glsa: ensure assert_diff gets correctly typed input (diff) | |
download | glsamaker-d2cd457ff85b3a970497b199ebb7e8668633c79e.tar.gz glsamaker-d2cd457ff85b3a970497b199ebb7e8668633c79e.tar.bz2 glsamaker-d2cd457ff85b3a970497b199ebb7e8668633c79e.zip |
models/glsa: return tuple in generate_mail_table_row
Tuples are better when the object is intended to be a particular
length, as it is in this case.
Signed-off-by: John Helmert III <ajak@gentoo.org>
-rw-r--r-- | glsamaker/models/glsa.py | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/glsamaker/models/glsa.py b/glsamaker/models/glsa.py index 7a0c800..e94e493 100644 --- a/glsamaker/models/glsa.py +++ b/glsamaker/models/glsa.py @@ -1,4 +1,5 @@ from datetime import datetime +from typing import Tuple from envelope import Envelope from flask import current_app as app @@ -213,7 +214,7 @@ class GLSA(base): unaffected_query: Query[Affected], include_package: bool = True, slot: str = "", - ): + ) -> Tuple[str, str, str]: if slot: vulnerable_query = vulnerable_query.filter(Affected.slot == slot) unaffected_query = unaffected_query.filter(Affected.slot == slot) @@ -241,11 +242,11 @@ class GLSA(base): else: unaffected_versionstr = "Vulnerable!" - return [ + return ( vulnerable_versions[0].pkg if include_package else "", vulnerable_versionstr, unaffected_versionstr, - ] + ) def generate_mail_table(self) -> str: headers = ["Package", "Vulnerable", "Unaffected"] |