diff options
| author |   Robin H. Johnson <robbat2@gentoo.org> | 2021-10-21 21:53:31 -0700 |
|---|---|---|
| committer | Robin H. Johnson <robbat2@gentoo.org> | 2021-10-21 21:53:31 -0700 |
| commit | 5c27754bc4bb3c5bd092b701413b0f41388415b6 (patch) | |
| tree | 168e9102351f176e6deb797e7446facc8458c849 | |
| parent | local/require-signed-push: document push time requirements and improve error ... (diff) | |
| download | githooks-require-signed-push-clarity.tar.gz githooks-require-signed-push-clarity.tar.bz2 githooks-require-signed-push-clarity.zip | |
local/require-signed-push: clarify how delays in smartcard show uprequire-signed-push-clarity
Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
| -rwxr-xr-x | local/require-signed-push | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/local/require-signed-push b/local/require-signed-push index 20bc2e1..447e14a 100755 --- a/local/require-signed-push +++ b/local/require-signed-push @@ -98,7 +98,7 @@ verify_pusher_clock() { # Timestamps: # T0: nonce generation time (server, trusted input) - # T1: nonce signature time (client, untrusted input!) + # T1: nonce signature START time (client, untrusted input!) # T2: signed-nonce receive time (server, trusted input) T0="$SERVER_NONCE_TIME" T1="$PUSHER_SIGN_TIME" @@ -111,9 +111,11 @@ verify_pusher_clock() { # T2-T0: how long the roundtrip took (only contains trusted inputs) # - will only be negative if the server clock jump backwards during the round-trip! # - # T2-T1: how long it took the client to send the signed nonce back (depends on untrusted input) + # T2-T1: how long it took the client to sign their timestamp & nonce and + # send it back (depends on untrusted input) # - will be negative if the client (T1) has a clock AHEAD of server (T2), # e.g. clock is "fast" + # - MAY contain delay from smartcards/tokens requiring interaction. DELTA_T1_T0=$(( T1 - T0 )) DELTA_T2_T0=$(( T2 - T0 )) DELTA_T2_T1=$(( T2 - T1 )) |