summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorUlrich Müller <ulm@gentoo.org>2024-09-30 17:57:25 +0200
committerUlrich Müller <ulm@gentoo.org>2024-10-02 23:00:39 +0200
commitdb62163b2b3182f280d539c2dbbfce09415b355c (patch)
treee8d64a5b6453531e80025894cd5546058b282706
parentDrop redundant XEmacs conditionals in tests (diff)
downloadebuild-mode-db62163b2b3182f280d539c2dbbfce09415b355c.tar.gz
ebuild-mode-db62163b2b3182f280d539c2dbbfce09415b355c.tar.bz2
ebuild-mode-db62163b2b3182f280d539c2dbbfce09415b355c.zip
Remove unnecessary *-run-silently wrappers in tests
* test/ebuild-mode-tests.el (ebuild-mode-test-skeleton): Remove unnecessary ebuild-mode-test-run-silently. * test/gentoo-newsitem-mode-tests.el (gentoo-newsitem-mode-test-skeleton): Remove unnecessary gentoo-newsitem-mode-test-run-silently. Signed-off-by: Ulrich Müller <ulm@gentoo.org>
-rw-r--r--ChangeLog8
-rw-r--r--test/ebuild-mode-tests.el13
-rw-r--r--test/gentoo-newsitem-mode-tests.el13
3 files changed, 20 insertions, 14 deletions
diff --git a/ChangeLog b/ChangeLog
index 2f0da00..4e803ca 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2024-09-30 Ulrich Müller <ulm@gentoo.org>
+
+ * test/ebuild-mode-tests.el (ebuild-mode-test-skeleton):
+ Remove unnecessary ebuild-mode-test-run-silently.
+ * test/gentoo-newsitem-mode-tests.el
+ (gentoo-newsitem-mode-test-skeleton): Remove unnecessary
+ gentoo-newsitem-mode-test-run-silently.
+
2024-09-28 Ulrich Müller <ulm@gentoo.org>
* test/ebuild-mode-tests.el:
diff --git a/test/ebuild-mode-tests.el b/test/ebuild-mode-tests.el
index c03ef7b..b566f24 100644
--- a/test/ebuild-mode-tests.el
+++ b/test/ebuild-mode-tests.el
@@ -224,13 +224,12 @@
"" ; IUSE
"")) ; RESTRICT
(ebuild-mode-test-run-with-fixed-time
- (ebuild-mode-test-run-silently
- (if (featurep 'xemacs)
- ;; prevent a segfault (seen with XEmacs 21.4.24 and 21.5.35)
- (cl-letf (((symbol-function 'pos-visible-in-window-p)
- (lambda (&rest _args) t)))
- (ebuild-mode-insert-skeleton))
- (ebuild-mode-insert-skeleton))))
+ (if (featurep 'xemacs)
+ ;; prevent a segfault (seen with XEmacs 21.4.24 and 21.5.35)
+ (cl-letf (((symbol-function 'pos-visible-in-window-p)
+ (lambda (&rest _args) t)))
+ (ebuild-mode-insert-skeleton))
+ (ebuild-mode-insert-skeleton)))
(should (string-equal
(buffer-string)
(concat "# Copyright 2024 Gentoo Authors\n"
diff --git a/test/gentoo-newsitem-mode-tests.el b/test/gentoo-newsitem-mode-tests.el
index 30b6522..c785153 100644
--- a/test/gentoo-newsitem-mode-tests.el
+++ b/test/gentoo-newsitem-mode-tests.el
@@ -72,13 +72,12 @@
"" ; Display-If-Installed
"" ; Display-If-Keyword
"")) ; Display-If-Profile
- (gentoo-newsitem-mode-test-run-silently
- (if (featurep 'xemacs)
- ;; prevent a segfault (seen with XEmacs 21.4.24 and 21.5.35)
- (cl-letf (((symbol-function 'pos-visible-in-window-p)
- (lambda (&rest _args) t)))
- (gentoo-newsitem-insert-skeleton))
- (gentoo-newsitem-insert-skeleton)))
+ (if (featurep 'xemacs)
+ ;; prevent a segfault (seen with XEmacs 21.4.24 and 21.5.35)
+ (cl-letf (((symbol-function 'pos-visible-in-window-p)
+ (lambda (&rest _args) t)))
+ (gentoo-newsitem-insert-skeleton))
+ (gentoo-newsitem-insert-skeleton))
(should (string-equal
(buffer-string)
(concat "Title: Skeleton test\n"