diff options
author | Eli Schwartz <eschwartz93@gmail.com> | 2024-04-03 22:40:31 -0400 |
---|---|---|
committer | Sam James <sam@gentoo.org> | 2024-04-05 02:20:51 +0100 |
commit | a29e18c24eacd7f6a85b56adb8e2782c6307683f (patch) | |
tree | 497e6702672fe8bd91691ef364ed67187fed7e27 /media-gfx/sane-backends/sane-backends-1.2.1.ebuild | |
parent | media-gfx/sane-backends: drop outdated seds from 1.2.1 (diff) | |
download | gentoo-a29e18c24eacd7f6a85b56adb8e2782c6307683f.tar.gz gentoo-a29e18c24eacd7f6a85b56adb8e2782c6307683f.tar.bz2 gentoo-a29e18c24eacd7f6a85b56adb8e2782c6307683f.zip |
media-gfx/sane-backends: remove confusing and outdated seds
* SED: the following did not cause any changes
* sed -i -e "/by sane-desc 3.5 from sane-backends/s:sane-backends .*:sane-backends ${ver}:" testsuite/tools/data/html* || die;
* no-op: -e /by sane-desc 3.5 from sane-backends/s:sane-backends .*:sane-backends 1.2.1:
This is seemingly redundant since upstream ticket:
https://gitlab.com/sane-project/backends/-/issues/228
The sources are changed with a minor version bump to sane-desc (not
sane-backends!) such that the sed no longer applies. Seds are wonderful!
Especially at silently failing and never being noticed.
The tests do still pass, regardless of commented claims in the ebuild.
Is that because the issue was misdiagnosed? Is that because the upstream
ticket to remove timestamps made the issue obsolete? I don't know, and
I'm not fussed about finding out. The tests have passed for years
without this, so that's good enough for me.
Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Signed-off-by: Sam James <sam@gentoo.org>
Diffstat (limited to 'media-gfx/sane-backends/sane-backends-1.2.1.ebuild')
-rw-r--r-- | media-gfx/sane-backends/sane-backends-1.2.1.ebuild | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/media-gfx/sane-backends/sane-backends-1.2.1.ebuild b/media-gfx/sane-backends/sane-backends-1.2.1.ebuild index 11edb9d15f94..2b69e30c7d17 100644 --- a/media-gfx/sane-backends/sane-backends-1.2.1.ebuild +++ b/media-gfx/sane-backends/sane-backends-1.2.1.ebuild @@ -192,12 +192,6 @@ src_prepare() { eautoreconf - # Fix for "make check". Upstream sometimes forgets to update this. - local ver=$(./configure --version | awk '{print $NF; exit 0}') - sed -i \ - -e "/by sane-desc 3.5 from sane-backends/s:sane-backends .*:sane-backends ${ver}:" \ - testsuite/tools/data/html* || die - # Needed for udev rules generation/installation multilib_copy_sources } |