summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKerin Millar <kfm@plushkava.net>2022-12-04 10:42:25 +0000
committerSam James <sam@gentoo.org>2022-12-06 09:11:28 +0000
commit6a02df6f8f73f9d69ec9524f33adf761717118d4 (patch)
treee3d1f8088a0bd3d5d4e05077598fb5f222df3e23 /app-editors/jupp
parentapp-dicts/*: Apply patsub_replacement defences (diff)
downloadgentoo-6a02df6f8f73f9d69ec9524f33adf761717118d4.tar.gz
gentoo-6a02df6f8f73f9d69ec9524f33adf761717118d4.tar.bz2
gentoo-6a02df6f8f73f9d69ec9524f33adf761717118d4.zip
app-editors/jupp: Apply patsub_replacement defences
Per bug #881383, string replacing forms of parameter expansion must take care to quote - or appropriately escape - any nested parameter expansions, assuming that their values are intended to be taken literally (as is almost invariably the case). This has long been the case, but the introduction of the new patsub_replacement option in bash >=5.2 has brought the issue to the fore. In the case of the app-editors/jupp package, the improper quoting is not yet causing any issues. Still, it is better to write the code properly to begin with, especially considering the demonstrative value of robust code. Signed-off-by: Kerin Millar <kfm@plushkava.net> Bug: https://bugs.gentoo.org/881383 Signed-off-by: Sam James <sam@gentoo.org>
Diffstat (limited to 'app-editors/jupp')
-rw-r--r--app-editors/jupp/jupp-3.1_p41.ebuild2
1 files changed, 1 insertions, 1 deletions
diff --git a/app-editors/jupp/jupp-3.1_p41.ebuild b/app-editors/jupp/jupp-3.1_p41.ebuild
index cfdbb37a9585..3e6e016b519c 100644
--- a/app-editors/jupp/jupp-3.1_p41.ebuild
+++ b/app-editors/jupp/jupp-3.1_p41.ebuild
@@ -5,7 +5,7 @@ EAPI=8
DESCRIPTION="Portable version of Joe's Own Editor"
HOMEPAGE="http://www.mirbsd.org/jupp.htm"
-SRC_URI="http://www.mirbsd.org/MirOS/dist/${PN}/joe-${PV/_p/${PN}}.tgz"
+SRC_URI="http://www.mirbsd.org/MirOS/dist/${PN}/joe-${PV/_p/"${PN}"}.tgz"
S="${WORKDIR}/${PN}"
LICENSE="GPL-1"